Closed mcanouil closed 1 year ago
I added --freq
, --missing
, and --hardy
from PLINK2.
This will now produce the following output:
Note that FDR, BONFERRONI, etc. columns are only there to allow individual cohorts to reuse "locally" the summary statistics. It's not necessarily for use in the meta-analysis.
@annihei Let me know, if the changes suit the group, see #97 for more details.
@annihei Is the final word to remove HWE test?
Does the other changes seem fine to you? If so, could you mark the different threads above using the "Resolve conversation" buttons?
@mcanouil Yes let's drop the HWE_P. I have been trying to double check the other changes, will comment on those.
I think we should also drop the --mach-r2-filter
flag in all PLINK2 commands as this was not in analysis plan and we filter based on INFO in the meta-analysis team.
I think we should also drop the
--mach-r2-filter
flag in all PLINK2 commands as this was not in analysis plan and we filter based on INFO in the meta-analysis team.
Removed in aa18ffc323b45c6cb9c4fcc39ad681a5f82390aa
HWE commands/outputs removed in c7c09c69c431d33c8dc5304a94808431f8248a98
@annihei You should be able to install the version from this PR using the following command: remotes::install_github("mcanouil/eggla@fix/issue96")
.
Note that, the column names might not match exactly the analysis plan (I did not check that yet). Either, we update the analysis plan to match the R package (It would make more sense that way to me), or we rename the output columns within the R package.
OK, thanks. I'll try these.
For reference, the current GWAS results output
It seems OBS_CT
and MISSING_CT
does not count DS data but only hardcall genotypes
Now, the values checks out.
Note that Call rate is based on hard call for now. Should it be computed on dosage?
F_MISS_DOSAGE
as described in https://www.cog-genomics.org/plink/2.0/formats#vmiss
To-do:
CALL_RATE
which represents m, in the current analysis output, the genotyped rate.ERRCODE
description.After all discussions, below is the current output from the GWAS.
Fixes
R/run_eggla_gwas.R
,vep_file
as the top level parameter instead ofvep
.--mach-r2-filter
PLINK2 option.R/plot_aucs.R
,R/plot_egg_aucs.R
, andR/run_eggla_lmm.R
,groupOnX
argument ofgeom_quasirandom()
is deprecated as of ggbeeswarm 0.7.1.R/plot_slopes.R
andR/plot_egg_slopes.R
,size
aesthetic for lines was deprecated.Chores
.devcontainer
settings into a separate repositories, i.e.,.vscode
and.devcontainer
.Build
After all discussions, below is the current output from the GWAS.