mcanouil / eggla

Early Growth Genetics Longitudinal Analysis.
https://m.canouil.dev/eggla/
Other
2 stars 1 forks source link

Update default value for compute_apar function #98

Closed nwarrington closed 1 year ago

nwarrington commented 1 year ago

Bug description

When predicting the age at adiposity peak and rebound in the cohorts, we found that the age at adiposity peak only had 4 or 5 values (e.g. 0.65, 0.7, 0.75, 0.8, 0.85years). This was causing issues when we then excluded outliers in some cohorts as all but one category was flagged as an outlier. The current default 'step' in the compute_apar() function is 0.05. Could we please change this to 0.01? This extra resolution seems to resolve the issues within the cohorts we have tested.

The code that needs changing is as follows (version 0.18.5):

Current code: function (fit, from = c("predicted", "observed"), start = 0.25, end = 10, step = 0.05, filter = NULL) Updated code: function (fit, from = c("predicted", "observed"), start = 0.25, end = 10, step = 0.01, filter = NULL)

eggla version output

packageVersion('eggla') [1] ‘0.18.5’

Checklist

mcanouil commented 1 year ago

I changed it everywhere and improved some internals related to that.