search

mcb80x / minimal-player

A very stripped down MCB80x player
3 stars 1 forks source link

remove inline styles #105

Open cameron opened 10 years ago

cameron commented 10 years ago

https://github.com/mcb80x/minimal-player/blob/master/templates/player.jade#L3

No! :)

davidcox commented 10 years ago

Ha ha. This is was some serious "fog-of-war" late-night monkey-patched stuff from the original live site (HackReactor folks had nothing to do with it). We of course definitely should clean it up in the original repo.

cameron commented 10 years ago

Yeah I didn't start looking at the contributor lines until well into my feedback. Sadly, I think most of it is on the code you didn't write. We'll talk more this afternoon :)

davidcox commented 10 years ago

You'll definitely want to keep track of that; the minimal-player thing was a hatchet job to get Katie and Allegra the minimal working baseline to work from with the minimum number of dependencies. A lot of it only makes sense in the context of the whole, and the whole project could use a good cleaning.

On Thu, Apr 17, 2014 at 2:39 PM, Cameron Boehmer notifications@github.comwrote:

Yeah I didn't start looking at the contributor lines until well into my feedback. Sadly, I think most of it is on the code you didn't write. We'll talk more this afternoon :)

— Reply to this email directly or view it on GitHubhttps://github.com/mcb80x/minimal-player/issues/105#issuecomment-40747829 .