mcespedes99 / sEEGPrep

1 stars 0 forks source link

epoch extraction depends on a column name that not in the BIDS spec #15

Open akhanf opened 3 months ago

akhanf commented 3 months ago

You use the event column, but that isn't in the bids spec (not even as a listed but optional column). An optional column in the bids spec that would probably make more sense to use here is trial_type, but should probably make this configurable on the CLI.

https://github.com/mcespedes99/sEEGPrep/blob/8712f12013aa149c2e629139d3b6adbf6fe61d9f/seegprep/workflow/Snakefile#L57

mcespedes99 commented 1 month ago

Updated in commit https://github.com/mcespedes99/sEEGPrep/commit/60009b5e506358edf304dd946b91c5d8858c327e Missing sanity check