search

mclear-tools / tabspaces

GNU General Public License v3.0
234 stars 16 forks source link

Fixup and extra prompt information #47

Closed dalugm closed 9 months ago

dalugm commented 12 months ago

Add additional prompts when remove buffer from tabspace

Sometimes I find that when removing a buffer from a tabspace, I still need to confirm whether I am in the correct tabspace.

Adding this works good for me, I guess we can merge it? ;)

Second update:

As the commit show, fix the command tabspaces-remove-current-buffer since it totally can't work right now, I rewrite it so tabspaces-remove-select-buffer can use it too.

And I make tabspaces--add-to-default-tabspace do its work without checking tabspaces-remove-to-default (From the function's name, tabspaces--add-to-default-tabspace should only care about add the removed buffer to tabspaces-default-tab, it shouldn't check the condition inside the function).

dalugm commented 11 months ago

Hi @mclearc, can you check this pr on your free time?

Currently tabspaces-remove-current-buffer is not working, and I believe this fixed that problem =) It has been three weeks and it works fine on my machine. Please let me know if you have any more questions.

mclearc commented 9 months ago

I ended up revising some of this myself (there were also conflicts with another PR I merged), in keeping with the old function naming scheme. But I appreciate the pull request and apologies for my being so slow in acting.