search

mclemente / fvtt-module-polyglot

Talk to others using a language you can speak and scrambles text you can't understand.
MIT License
41 stars 48 forks source link

Default language not working #121

Closed Danii0206 closed 3 years ago

Danii0206 commented 3 years ago

I'm using the system "Das schwarze Auge" (DSA). When I set the language "Garethi" as default in the module settings, the language selection dropdown disappears from above the chat-textfield. Console throws this error:

Uncaught (in promise) TypeError: Cannot read property 'toLowerCase' of undefined at PolyGlot.updateUserLanguages (polyglot.js:300) at PolyGlot.setCustomLanguages (polyglot.js:594)

mclemente commented 3 years ago

Strange, I could not reproduce this bug. Does the bug persist after you reload the application? Also, did you set Garethi as a Custom Language first? I'm not sure if its an actual DSA language or not, since it doesn't have the fonts set up.

Nyhles commented 3 years ago

I'll try to replicate it today in the afternoon. Can you post screenshots of the Settings you used?

Danii0206 commented 3 years ago

Yes, the bug persists after reload.

No I did not set Garethi as Custom Language, because it is an actual (the most common) language in DSA. Screenshot from 2021-04-28 15-33-56

I just set it as Default... Screenshot from 2021-04-28 15-29-51

Restart Foundry for Changes to take place.

... and the Language drop-down disappears. Screenshot from 2021-04-28 15-31-39

Nyhles commented 3 years ago

I too could not replicate that error. Garethi is set up in the modules/dsa5,json as a tongue, so the system uses the right font which it does as seen in screenshot 1

Nyhles commented 3 years ago

Adding to this, now I have been able to reproduce this error. I forgot to reload foundry.

Danii0206 commented 3 years ago

I edited the reload in my report above for easier replication instructions.

mclemente commented 3 years ago

Update and check if it still isn't working, I've made Garethi the default language for the system.

Danii0206 commented 3 years ago

Thank you! :)