search

mclemente / fvtt-module-polyglot

Talk to others using a language you can speak and scrambles text you can't understand.
MIT License
41 stars 48 forks source link

Settings not saving #302

Closed Imper1um closed 1 year ago

Imper1um commented 1 year ago

Describe the bug When you make a change to the Language, those settings do not save to the Server.

To Reproduce Steps to reproduce the behavior:

  1. Go to Configure Settings.
  2. Go to Polyglot
  3. Click on Language Settings
  4. Make any change to Languages (Font, Random). Click Save Changes.
  5. In Configure Settings, click Save Settings.
  6. Try speaking in the specified language that you made the modification.
  7. On your local machine, the language is set properly, but on other users' screens, it will be the original defaults.
  8. Reload the webpage on the Local Machine.
  9. Go to Configure Settings
  10. Go to Polyglot
  11. Click on Language Settings.
  12. Notice that changes have reverted to default.

Expected behavior Changes to languages propagate to the server.

Versions

Imper1um commented 1 year ago

Issue Persists on v2.0.2

mclemente commented 1 year ago

I've fixed it now.

Only thing that isn't "fixed" is the server propagation, because I don't think GMs change their settings mid-session that often, and the best way to propagate would require refreshing and that would be annoying when setting the languages.