mclemente / fvtt-module-polyglot

Talk to others using a language you can speak and scrambles text you can't understand.
MIT License
41 stars 48 forks source link

Some users cannot edit Journals with TinyMCE/Default Text Page Sheet #308

Closed CeaneC closed 1 year ago

CeaneC commented 1 year ago

Describe the bug One of my players is unable to edit his journals when Polyglot is enabled. A TypeError is logged in the console, see screenshots for the error. This only occurs when using the TinyMCE and Default Text Page Sheet (which I think is ProseMirror?) editors - Markdown works fine. He's also the only player affected by the issue; his journals work fine for me.

To Reproduce Steps to reproduce the behavior:

  1. Open a journal
  2. Open a page on the journal
  3. Edit the page
  4. Have the edit sheet be set to TinyMCE or Default Text Page Sheet
  5. See that you cannot edit the journal, and an error is logged in the console

Expected behavior The journal page is editable

Screenshots The edit page on the left, which is missing all of the formatting options and doesn't let the player type in it: image

The error that gets logged in the console when opening the edit page: image

Additional context I've tested it with only Polyglot and libWrapper enabled, and the issue persists for him. I do not use Monk's Journal Enhancements.

mclemente commented 1 year ago

I can't reproduce that error. Could you try opening Polyglot's Language Settings and saving/resetting it and check if the error persists?

CeaneC commented 1 year ago

Found the cause - he had a custom language on his character sheet in the "Special" section, that hadn't been added to the Custom Languages in Polyglot's General Settings. After adding it to the Custom Languages, he can edit his journal again

mclemente commented 1 year ago

I see, I managed to reproduce with Special languages.

After adding it to the Custom Languages, he can edit his journal again

That shouldn't have been needed, though, this was a bug. It should be fixed on v2.1.1 now.