search

mcneel / rhinocommon

RhinoCommon is the .NET SDK for Rhino5 / Grasshopper
http://wiki.mcneel.com/developer/rhinocommon
242 stars 92 forks source link

Point3d.Unset should have a special string ovevrride #184

Open goswinr opened 5 years ago

goswinr commented 5 years ago

When calling ToString() on Point3d.Unset it prints -1.23432101234321E+308,-1.23432101234321E+308,-1.23432101234321E+308 a string literal like Point3d.Unset or Point3d.Unset (-1.2E+308, -1.2E+308, -1.2E+308) would be nicer so that it is explicit that this is a special point value. This helps in debugging too. at line https://github.com/mcneel/rhinocommon/blob/57c3967e33d18205efbe6a14db488319c276cbee/dotnet/opennurbs/opennurbs_point.cs#L1872

goswinr commented 5 years ago

I would in general add a type annotation and format any point as Point3d(1,2,3) instead of 1,2,3 but i understand that this might be a problem if someone relies on the current behaviour.