search

mcollina / fastq

Fast, in memory work queue
ISC License
943 stars 47 forks source link

validate concurrency parameter #32

Closed codekitchen closed 3 years ago

codekitchen commented 3 years ago

I recently ran into a bug in fast-glob where it was setting concurrency: 0 in some environments. This triggers a nasty situation where all work is just queued up forever and fastq silently never makes progress.

It might be good to validate the concurrency parameter and not allow a value less than 1.

mcollina commented 3 years ago

Good spot! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

KyleAMathews commented 3 years ago

This should be closed