mdarifmustafa / vt-middleware

Automatically exported from code.google.com/p/vt-middleware
0 stars 0 forks source link

vt-ldap: pooling code review #120

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The pooling API changed to support the following workflow:

Connection c = null;
try {
  c = pool.getConnection();
  ...
} finally {
  c.close();
}

The implementation inherits from Connection rather than using a proxy because 
Connection is not an interface in the current API.
Review the current implementation and comment.

http://code.google.com/p/vt-middleware/source/detail?r=2052

Original issue reported on code.google.com by dfis...@gmail.com on 25 Aug 2011 at 1:37

GoogleCodeExporter commented 8 years ago
I reviewed this code outside the issue tracker and spoke with Daniel directly.  
Changes look good.

Original comment by marvin.addison@gmail.com on 7 Nov 2011 at 6:13