mdarifmustafa / vt-middleware

Automatically exported from code.google.com/p/vt-middleware
0 stars 0 forks source link

vt-password: Reverse dictionary rule checks should not be done for single character words #186

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
AbstractDictionaryRule#validate checks if a password is in a dictionary 
forwards and optionally reversed. It does the reverse check for single 
character passwords for which password == password.reverse(). This causes 
duplicate error messages. e.g. "Password contains the dictionary word 'a'" and 
"Password contains the dictionary word 'a'".

The if(matchBackwards) check should be something like if(matchBackwords && 
passwordData.getPassword().getText().length() > 1).

Original issue reported on code.google.com by max.spi...@york.ac.uk on 2 Aug 2013 at 3:19

GoogleCodeExporter commented 8 years ago

Original comment by dfis...@gmail.com on 2 Aug 2013 at 6:15

GoogleCodeExporter commented 8 years ago
Fixed in r2804.

Original comment by dfis...@gmail.com on 2 Aug 2013 at 6:25