search

mde / true

A JavaScript port of the Unix utility 'true'. Returns the Boolean value `true`
101 stars 26 forks source link

Lots of improvements. #34

Open tj-commits opened 6 months ago

tj-commits commented 6 months ago

THESE FIXES ARE CRUCIAL AND SOLVE MANY PROBLEMS

resolves #5 i made the module.exports immutable using @Ginden 's solution resolves #19 i made true not hardcode using @tfrijsewijk's solution also makes bin/cli.js actually log "true". also there was a ./true in the require function in readme.md which is a hint from testing periods. This would not work if someone installed, therefore this is a crucial fix

i have also done the same things but for false on the https://github.com/mde/false mde/false library

tj-commits commented 6 months ago

Can we merge pull request

mde commented 4 months ago

It's vital to keep such a critical piece of Internet infrastructure free of heavy dependencies, so I'm not keen on this approach. Worth considering if you can find a way to do this without requiring external modules.

tj-commits commented 4 months ago

@mde Hmm, okay. But besides that I also provided some more fixes. Should those be applied? Like, updating the README.md to be more accurate, and adding CLI to https://github.com/mde/false.