search

mdedetrich / scalajson

ScalaJSON - JSON for Scala, currently contains minimal AST
BSD 3-Clause "New" or "Revised" License
55 stars 10 forks source link

Remove numericStringEquals? #36

Open mdedetrich opened 7 years ago

mdedetrich commented 7 years ago

@sirthias argument https://github.com/mdedetrich/scalajson/pull/30#discussion_r125457393

mdedetrich commented 7 years ago

Also in response to this comment

The question of whether it's even feasible to properly do equality on arbitrary JSON numbers is a second issue. Is there a proper testsuite for the currently implemented "magic" equality implementation?

There is, you can see it in the various test folders in scalaJSON (i.e. https://github.com/mdedetrich/scalajson/blob/master/js/src/test/scala/specs/JNumber.scala and https://github.com/mdedetrich/scalajson/blob/master/jvm/src/test/scala/specs/JNumber.scala)