search

mdedwards / slippery-chicken

slippery chicken: algorithmic composition software in common lisp and clos
http://michael-edwards.org/sc
72 stars 3 forks source link

reaper-play: derive automatic file-path from default-dir #73

Closed rubenphilipp closed 11 months ago

rubenphilipp commented 11 months ago

Hey Michael,

thanks again for your work on reaper-play. Did you have anything specific in mind when deciding that the default path for the rpp-file (when :file = NIL) is relative to the CWD of the current CL-instance instead of, for example, to the default-dir (e.g. via default-dir-file)? I find this slightly confusing, as this differs from common slippery chicken "behavior" and suggest changing the default file-path as described above.

Best Ruben

mdedwards commented 11 months ago

Hello Ruben, that was just an oversight and something I'd probably had picked up when making my first piece with the method. Feel free to improve but maybe the tests need changing to read from /tmp. Best, Michael

rubenphilipp commented 11 months ago

I have fixed this and will push a commit in a moment. The tests did not need to be changed.