search

mdedwards / slippery-chicken

slippery chicken: algorithmic composition software in common lisp and clos
http://michael-edwards.org/sc
72 stars 3 forks source link

removing ppcre workaround on quicklisp branch #83

Closed Leon-Focker closed 8 months ago

Leon-Focker commented 8 months ago

When using asdf to manage the slippery-chicken system, the workaround for automatically cloning ppcre (see 41906ba) could be reverted to using asdf.

rubenphilipp commented 8 months ago

As the .asd now depends on cl-ppcre, try to remove (uncomment) (sc::import-ppcre) wherever it is defined (didn't check).

Leon-Focker commented 8 months ago

Currently import-ppcre is defined in utilities and called in all.lsp Since all.lsp is ignored when using the .asd, we might leave everything as is for now?

rubenphilipp commented 8 months ago

This sounds sane. I'd suggest adding a note in the header comment mentioning that this file is not relevant when using asdf.

mdedwards commented 8 months ago

As import-ppcre is only used in all.lsp I've taken it out of utilities.lsp and put it in all.lsp instead.

Hell, I've also removed the cm-2.6.0 folder.

All tests passing. Closing.