toGridLengthHelper: fix double "fr" on "minmax" - Githubissues

mdgriffith / elm-ui

What if you never had to write CSS again?

https://package.elm-lang.org/packages/mdgriffith/elm-ui/latest/

BSD 3-Clause "New" or "Revised" License

1.36k stars 111 forks source link

toGridLengthHelper: fix double "fr" on "minmax" #366

Open PedroHLC opened 2 months ago

PedroHLC commented 2 months ago

Expected behavior

fillPortion 128 |> minimum 1 should create a grid column with minmax(1px, 128fr).

Current behavior

CSS was generating something like:

.grid-rows-auto-cols-min1128fr-88fr-140fr-142fr-216fr-space-x-0px-space-y-0px {
  grid-template-columns: minmax(1px, 128frfr) 88fr 140fr 142fr 216fr;
  # etc etc etc
}

The frfr breaks the entire rule. And the browser goes wild.

Suggested fix

Remove the repetition, s/frfr/fr/.

There are no tests covering grid, so I also didn't add one for this issue.