mdn / data

This repository contains general data for Web technologies
https://developer.mozilla.org
Creative Commons Zero v1.0 Universal
724 stars 189 forks source link

feat(css): Add stroke CSS SVG properties #757

Closed meyerweb closed 1 week ago

meyerweb commented 1 month ago

Description

Adds the properties stroke, stroke-dasharray, stroke-dashoffset, stroke-linecap, stroke-linejoin, stroke-miterlimit, stroke-opacity, and stroke-width.

Motivation

These properties are soon to be added to MDN reference content and need the formal syntax data to back them up.

Related issues and pull requests

Relates to https://github.com/mdn/content/issues/34763.

meyerweb commented 1 month ago

Hooray, I finally managed to get it to lint! Ready for merge, I hope.

bsmth commented 2 weeks ago

Thanks, Eric! There's a couple of conflicts now, do you want to have a look? I've added myself as reviewer for when you're ready

meyerweb commented 2 weeks ago

Thanks, Eric! There's a couple of conflicts now, do you want to have a look? I've added myself as reviewer for when you're ready

I think I resolved them β€”Β let me know if not, thanks!

estelle commented 2 weeks ago

Addresses https://github.com/mdn/data/issues/750

bsmth commented 2 weeks ago

Thanks, Eric! There's a couple of conflicts now, do you want to have a look? I've added myself as reviewer for when you're ready

I think I resolved them β€” let me know if not, thanks!

Taking a look now πŸ‘€

meyerweb commented 1 week ago

@bsmth I wrote some responses to your feedback on formal syntaxes; let me know how best to proceed.

meyerweb commented 1 week ago

Thanks, @meyerweb, I will merge shortly unless there's anything else outstanding, do you want to have a final check beforehand?

Nope, go for it!