search

mdn / webaudio-examples

Code examples that accompany the MDN Web Docs pages relating to Web Audio.
https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API
Creative Commons Zero v1.0 Universal
1.25k stars 434 forks source link

Add support for touch events to violent theremin demo #126

Open chrisdavidmills opened 3 years ago

chrisdavidmills commented 3 years ago

@normanr commented on Wed Dec 02 2020

It would be nice to be able to use the demo in a touch environment (eg: phone or tablet). (Not required: sound could be continuous after a 'start/down' event until an 'end/up' event is received)

@chrisdavidmills commented on Wed Dec 02 2020

I agree that this would be nice.

For reference:

@normanr commented on Wed Dec 02 2020

(side-note: the event listeners for triggering init should be removed in init, otherwise using the keyboard causes init to be triggered multi times, and DOMExceptions when trying to remove the startMessage that has already been removed).

Rumyra commented 3 years ago

Would it be ok to take this on and give it a bit of a re-write (inc touch events) and also move it into the webaudio-examples repo @chrisdavidmills ?

chrisdavidmills commented 3 years ago

@Rumyra yes, I'm fine with that. It is mentioned a few times on MDN, so make sure there is some kind of redirect in place.

Rumyra commented 3 years ago

Thank you! Yep I think I'm going to roll it into a bigger task of auditing audio, so I'm hoping that won't be too much of a problem 👍

github-actions[bot] commented 2 months ago

It looks like this is your first issue. Welcome! 👋 One of the project maintainers will be with you as soon as possible. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.