Closed eirikurj closed 1 year ago
Converting to draft for now. Will provide more detail later.
Merging #257 (8f1f91c) into main (33fb96d) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 40.77% 40.77%
=======================================
Files 13 13
Lines 3882 3882
=======================================
Hits 1583 1583
Misses 2299 2299
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Just to clarify, this one is ready for review
Purpose
As described in https://github.com/mdolab/adflow/issues/237, filenames for different output files are not consistently written out. This PR addresses these issues. Additionally, time-accurate and time-spectral files should now also be written consistently to stdout.
Closes #237
Expected output for steady cases
Expected output for one time-step
Expected time until merged
No rush
Type of change
Testing
Please test different problems and combinations to make sure it works as expected.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable