mdolab / adflow

ADflow is a finite volume RANS solver tailored for gradient-based aerodynamic design optimization.
Other
230 stars 100 forks source link

Updating stdout for output files written #257

Closed eirikurj closed 1 year ago

eirikurj commented 1 year ago

Purpose

As described in https://github.com/mdolab/adflow/issues/237, filenames for different output files are not consistently written out. This PR addresses these issues. Additionally, time-accurate and time-spectral files should now also be written consistently to stdout.

Closes #237

Expected output for steady cases

#
# Writing grid file(s):
#    outdir/wing_000_vol.cgns
# Grid file(s) written
#
#
# Writing volume solution file(s):
#    outdir/wing_000_vol.cgns
# Volume solution file(s) written
#
#
# Writing surface solution file(s):
#    outdir/wing_000_surf.cgns
# Surface solution file(s) written
#
#
# Writing slices file(s): 
#    outdir/wing_000_slices.dat
# Slices file(s) written
#
#
# Writing lift distribution file(s):
#    outdir/wing_000_lift.dat
# Lift distribution file(s) written
#
#
# Writing tecplot surface file(s):
#    outdir/wing_000_surf.plt
# Tecplot surface file(s) written

Expected output for one time-step

# Writing grid file(s):
#    outdir/wing_000_vol.cgnsTimestep2
#    outdir/wing_000_vol.cgnsTimestep1
# Grid file(s) written
#
#
# Writing volume solution file(s):
#    outdir/wing_000_vol.cgnsTimestep2
#    outdir/wing_000_vol.cgnsTimestep1
# Volume solution file(s) written
#
#
# Writing surface solution file(s):
#    outdir/wing_000_surf.cgnsTimestep0002
# Surface solution file(s) written
#
#
# Writing slices file(s): 
#    outdir/wing_000_slices_Timestep0002.dat
# Slices file(s) written
#
#
# Writing lift distribution file(s):
#    outdir/wing_000_lift_Timestep0002.dat
# Lift distribution file(s) written
#
#
# Writing tecplot surface file(s):
#    outdir/wing_000_surf_Timestep0002.plt
# Tecplot surface file(s) written
#

Expected time until merged

No rush

Type of change

Testing

Please test different problems and combinations to make sure it works as expected.

Checklist

eirikurj commented 1 year ago

Converting to draft for now. Will provide more detail later.

codecov[bot] commented 1 year ago

Codecov Report

Merging #257 (8f1f91c) into main (33fb96d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   40.77%   40.77%           
=======================================
  Files          13       13           
  Lines        3882     3882           
=======================================
  Hits         1583     1583           
  Misses       2299     2299           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eirikurj commented 1 year ago

Just to clarify, this one is ready for review