sseraj commented 1 year ago

Purpose

Closes #205

I ignored the dependencies in the dynamic stability files because they are unused and do not work. I opened a separate issue (#268) to remove or refactor those files.

Expected time until merged

1 week

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[x] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing

Checklist

[x] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 1 year ago

Codecov Report

Merging #269 (b79a1c6) into main (770e098) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   40.77%   40.77%           
=======================================
  Files          13       13           
  Lines        3882     3882           
=======================================
  Hits         1583     1583           
  Misses       2299     2299

Impacted Files	Coverage Δ
adflow/pyADflow.py	`66.62% <ø> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sseraj commented 1 year ago

I can't check the doc build from the tests

It's strange that clicking 'Details' isn't going straight to the docs page. You should be able to click 'View docs' from the build page to get there though.

mdolab / adflow