mdolab / adflow

ADflow is a finite volume RANS solver tailored for gradient-based aerodynamic design optimization.
Other
229 stars 100 forks source link

Fixed `sliceDir` index #351

Closed eytanadler closed 7 months ago

eytanadler commented 8 months ago

Purpose

In the addArbitrarySlices function, the slice direction was being indexed with the variable used to track the total slices so far, rather than the correct index looping over the slices to add.

Expected time until merged

Type of change

Testing

Checklist

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.45%. Comparing base (5f233c2) to head (8abd1cd).

Files Patch % Lines
adflow/pyADflow.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #351 +/- ## ======================================= Coverage 41.45% 41.45% ======================================= Files 13 13 Lines 4069 4069 ======================================= Hits 1687 1687 Misses 2382 2382 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.