mdolab / adflow

ADflow is a finite volume RANS solver tailored for gradient-based aerodynamic design optimization.
Other
229 stars 100 forks source link

Surface output for forces in lift and drag directions #358

Closed sseraj closed 1 month ago

sseraj commented 6 months ago

Purpose

This PR adds force coefficients per unit area projected in the lift and drag directions as surface output variables. Here is an example of the force in the drag direction for the MACH tutorial wing case: force_in_drag_dir

It would be great if the reviewers could test this on their own cases.

Expected time until merged

2-3 weeks

Type of change

Testing

No tests, but I tried this on wing and full aircraft cases and the outputs made sense.

Checklist

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.02%. Comparing base (20ff867) to head (f0958fd). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #358 +/- ## ======================================= Coverage 41.02% 41.02% ======================================= Files 13 13 Lines 4119 4119 ======================================= Hits 1690 1690 Misses 2429 2429 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marcomangano commented 1 month ago

@sanjan98 and I will take a look soon. I believe it is time to make a new release for ADflow. There are no breaking changes here, right @sseraj ? Likely a patch release will be enough.

sseraj commented 1 month ago

That's right, there are no breaking changes in this PR. There have been some breaking changes since the last release though, like #330 and #359 to some extent.

marcomangano commented 1 month ago

Ok, so we should go for a minor release overall, given all these changes since the latest one. We can wait for #362 to be merged since it's minor and should be ready by the end of the week. If @lamkina is ok we can bump the minor (?) version here in the meantime?

lamkina commented 1 month ago

I think bumping the minor version here makes sense. #362 is just adding tests so I don't think it needs to be factored into the version bump.