Closed sseraj closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 41.02%. Comparing base (
20ff867
) to head (f0958fd
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@sanjan98 and I will take a look soon. I believe it is time to make a new release for ADflow. There are no breaking changes here, right @sseraj ? Likely a patch release will be enough.
That's right, there are no breaking changes in this PR. There have been some breaking changes since the last release though, like #330 and #359 to some extent.
Ok, so we should go for a minor release overall, given all these changes since the latest one. We can wait for #362 to be merged since it's minor and should be ready by the end of the week. If @lamkina is ok we can bump the minor (?) version here in the meantime?
I think bumping the minor version here makes sense. #362 is just adding tests so I don't think it needs to be factored into the version bump.
Purpose
This PR adds force coefficients per unit area projected in the lift and drag directions as surface output variables. Here is an example of the force in the drag direction for the MACH tutorial wing case:
It would be great if the reviewers could test this on their own cases.
Expected time until merged
2-3 weeks
Type of change
Testing
No tests, but I tried this on wing and full aircraft cases and the outputs made sense.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable