search

mdolab / openconcept

OpenConcept: A toolkit for conceptual MDAO of aircraft with unconventional propulsion architectures
MIT License
36 stars 32 forks source link

Fixed heat exchanger coefficient used for pressure drop #44

Closed eytanadler closed 2 years ago

eytanadler commented 2 years ago

Purpose

There was a mistake in the heat exchanger PressureDrop component where the cold side coefficients were used also for the hot side, instead of the hot side coefficients. I don't think this will affect anything since the default option values for the cold and hot sides are the same and are rarely specified to be something else (never in the code as far as I can tell).

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

codecov[bot] commented 2 years ago

Codecov Report

Merging #44 (9b8966d) into main (805ebd2) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   80.27%   80.28%           
=======================================
  Files          84       84           
  Lines        8970     8974    +4     
=======================================
+ Hits         7201     7205    +4     
  Misses       1769     1769
Impacted Files Coverage Δ
thermal/heat_exchanger.py 99.46% <0.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more