We've used oEmbed for many websites already (twitter, reddit, youtube, ...). But there are still many sites that would benefit from getting custom oEmbed support instead of using meta-data parsing ( js/templates/base.js ). This issue will keep track of every service added to the extension.
How to proceed :
If you're not familiar with the extension read CONTRIBUTING.MD
Find a service you want to add support for by using this list of websites having an oEmbed API.
Create a custom template in js/templates/{serviceName}.js
If needed add a custom CSS sheet in css/templates/{serviceName}.css please try to re-use already existing CSS as much as possible.
Add your script and CSS sheet to the manifest.json file
Inject content into the container properly = every element you want to inject into the DOM should be created and inserted using JS, textNodes should be used to contain the data.
Once done, submit a PR, reference #140 in the body or title so the PR shows up in the conversation below
Ask questions if you're not sure about something !! Also please do not ask if you can work on this, just in case yes you can!!
Don't inject HTML directly using {parentNode}.innerHTML = {raw html} for security reasons, by doing that you allow people to inject malicious scripts through the extension. PRs doing this won't be reviewed and will be closed automatically
We've used oEmbed for many websites already (twitter, reddit, youtube, ...). But there are still many sites that would benefit from getting custom oEmbed support instead of using meta-data parsing (
js/templates/base.js). This issue will keep track of every service added to the extension.How to proceed :
js/templates/{serviceName}.jscss/templates/{serviceName}.cssplease try to re-use already existing CSS as much as possible.manifest.jsonfileAsk questions if you're not sure about something !! Also please do not ask if you can work on this, just in case yes you can!!
Don't inject HTML directly using
{parentNode}.innerHTML = {raw html}for security reasons, by doing that you allow people to inject malicious scripts through the extension. PRs doing this won't be reviewed and will be closed automatically