search

mdsol / mesos_cookbook

Chef cookbook for installing Apache Mesos
Other
78 stars 71 forks source link

fixed syntax errors for chef 11.14 in master.rb and slave.rb, and distro... #35

Closed victorhong closed 10 years ago

victorhong commented 10 years ago

fixed syntax errors for chef 11.14 in master.rb and slave.rb, and fixed distro naming for 'redhat' in install.rb. chef 11.14 did not like
zookeeper_path: zk_path and it likes :zookeeper_path => zk_path

harryw commented 10 years ago

@victorhong hey sorry for taking a few days to respond. Are you running under Ruby 1.8? The syntax you've changed is just standard Ruby 1.9 hash syntax (introduced in 1.9, although the old 1.8 syntax works too.

victorhong commented 10 years ago

@harryw Yeah, unfortunately, we are still on ruby 1.8.7.

harryw commented 10 years ago

@victorhong Honestly I think you're going to have a pretty bad time trying to maintain 1.8 compatibility at this point - it's way past out of support for even the most critical of patches and all the Chef/Ruby linting tools and guidance are now telling people to use 1.9-style syntax.

Even if your'e lucky enough to find syntactically-compatibile cookbooks and gems, you could easily find that they're semantically-incompatible since there have been some breaking changes along the way.

So although I sympathize if it's not your personal decision to stick with a version that's been obsolete for over a year already, I am going to have to decline to pretend to have real 1.8.7 support in this cookbook. You're free to just maintain your own fork of course, and this cookbook isn't changing fast so that probably should not be a problem for you.

Good luck, you'll need it! :)