mdsol / mesos_cookbook

Chef cookbook for installing Apache Mesos
Other
78 stars 71 forks source link

Add switch for default cookbook repository #83

Closed rveznaver closed 9 years ago

rveznaver commented 9 years ago

If someone would like to mirror the mesosphere repository on their own infrastructure, or have their own packages, one should be able to disable the default mesosphere repository.

rayrod2030 commented 9 years ago

This looks good and is probably a much better alternative to both installing a custom built binary and/or compiling from source from within the cookbook as I had brought up as possible features. Makes sense that most places running Mesos in production would choose to pre-build and pre-package (deb/rpm) their custom Mesos builds. Running this through integration tests now. Have you been able to try this out with a custom package repo?

rayrod2030 commented 9 years ago

This change fails all centos based integration tests as it looks like 0.22.0 is being installed regardless of what mesos version is set via the cookbook attributes. I'm guessing this is due to changes in the way we search for and install specific mesos versions from the mesosphere RPM repo. These are the failing suites:

rveznaver commented 9 years ago

Have not been able to test it with a custom repo yet, but I'm pretty sure it will work with our use case (a wrapper cookbook).

rveznaver commented 9 years ago

The yum_package provider did not handle the version attribute correctly (meaning: at all) before Chef 2.1.0. The kitchen.yml tests are set to "require_chef_omnibus: 12.0.3". I've done a test with the newest chef version and it works. Maybe we should set a newer chef version?

rayrod2030 commented 9 years ago

I am testing against chef 12.1.2 and still see the issues.

rveznaver commented 9 years ago

Hi @rayrod2030, you're right. The yum_package provider does not support passing a ruby block to the version. I have patched and rebased. Should be fine now.

rayrod2030 commented 9 years ago

All integration tests passed. Merging!