Suggestion: remove compile time workarounds (+ dependency on chef-sugar)

mdsol / mesos_cookbook

Chef cookbook for installing Apache Mesos

Other

78 stars 71 forks source link

Suggestion: remove compile time workarounds (+ dependency on chef-sugar) #87

Closed rveznaver closed 8 years ago

rveznaver commented 9 years ago

As far as I could see, the only reason there is a dependency on chef-sugar are the "compile_time" options. These are here because the yum package provider is not smart enough to regex the version. I suggest we remove setting up things in compile time and create an attribute for the package version. The trade-off between not having an automatic package version finder and removing compile time workarounds is probably worth it. Comments?

rayrod2030 commented 9 years ago

Hey @rveznaver will try to get to all of this during the weekend. Started a new job this week so it's been really busy for me. Touch base soon!

rveznaver commented 9 years ago

Sounds good. The only issue I see here is...

nobeer

rayrod2030 commented 9 years ago

:beers: Cheers!

rayrod2030 commented 9 years ago

Hey @rveznaver I think this idea is making more sense based on some recent issues with chef-sugar compile time compatibility. Let me have a look at it today.

rayrod2030 commented 9 years ago

My concern here is that package version names often change outside of major Mesos release announcements so I'm not sure how we would keep the full package names up to date via attributes. Any thoughts on that? Should the onus be on the cookbook user to make sure they are configuring with the right package name?