search

mdwiltfong / secret-santa

https://codecademy-secret-santa-2.fly.dev/
3 stars 6 forks source link

added react date picker and disabled past dates #58

Open ivavay opened 6 months ago

mdwiltfong commented 5 months ago

Uh oh! Looks like the linter picked up on an any type. https://github.com/mdwiltfong/secret-santa/actions/runs/8625927437/job/23688785450

ivavay commented 5 months ago

Oh! Should I remove the any type?

On Thu, Apr 11, 2024 at 10:24 AM Michael Wiltfong @.***> wrote:

Uh oh! Looks like the linter picked up on an any type.

https://github.com/mdwiltfong/secret-santa/actions/runs/8625927437/job/23688785450

— Reply to this email directly, view it on GitHub https://github.com/mdwiltfong/secret-santa/pull/58#issuecomment-2048824040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AITREXVZ56STZHPCA2DMCLTY4XX5XAVCNFSM6AAAAABF2C7WZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYHAZDIMBUGA . You are receiving this because you authored the thread.Message ID: @.***>

mdwiltfong commented 5 months ago

Oh! Should I remove the any type? … On Thu, Apr 11, 2024 at 10:24 AM Michael Wiltfong @.> wrote: Uh oh! Looks like the linter picked up on an any type. https://github.com/mdwiltfong/secret-santa/actions/runs/8625927437/job/23688785450 — Reply to this email directly, view it on GitHub <#58 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AITREXVZ56STZHPCA2DMCLTY4XX5XAVCNFSM6AAAAABF2C7WZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYHAZDIMBUGA . You are receiving this because you authored the thread.Message ID: @.>

Yes! Is there a specific reason why it should be any?

ivavay commented 5 months ago

I removed the any type but I'm not sure if I can make another regular PR since these commits to sessionform branch were all included in this draft PR.