mdx-editor / editor

A rich text editor React component for markdown
https://mdxeditor.dev
MIT License
2.08k stars 160 forks source link

fix: i18n key for delete image functionality #634

Closed JohnsonMao closed 5 days ago

JohnsonMao commented 1 week ago

While adding support for multiple languages, I noticed that the translation for "Delete image" was not working. Upon investigation, I found that the key for "Delete image" was missing under imageEditor.

Currently, to apply the correct translation, we need to use image.delete:

{
    "image": {
        "delete": "Delete image"
    },
    "imageEditor": {
        "editImage": "Edit image"
    }
}

Expected Update Move the "Delete image" key under imageEditor for consistency:

{
    "imageEditor": {
        "deleteImage": "Delete image",
        "editImage": "Edit image"
    }
}

As a non-native English speaker, I welcome any suggestions for improvement.

image
petyosi commented 1 week ago

I will merge that soon, thank you.

github-actions[bot] commented 5 days ago

:tada: This PR is included in version 3.19.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: