me-no-dev / AsyncTCP

Async TCP Library for ESP32
GNU Lesser General Public License v3.0
755 stars 438 forks source link

Fix #111 Double-Free in _handle_async_event() #112

Closed ul-gh closed 4 years ago

ul-gh commented 4 years ago

Also replace deprecated xQueueSend() by identical xQueueSendToBack() Also add some comments explaining function _remove_events_with_arg()

Please check if the double-free is the correct observation, I did not test this.

ul-gh commented 4 years ago

See issue description, since the event pointers are unique, the original code is OK.

brunojoyal commented 3 years ago

@ul-gh @me-no-dev I am seeing substantial performance and stability improvements using @ul-gh's stack:

https://github.com/ul-gh/AsyncTCP/tree/Fix_%23111

https://github.com/ul-gh/ESPAsyncWebServer/tree/dev

Would both or either of these be ready for a PR? It would be a shame for this good work to fall through the cracks. Many thanks.