search

me-no-dev / AsyncTCP

Async TCP Library for ESP32
GNU Lesser General Public License v3.0
750 stars 433 forks source link

Bugfix: Make library work with ESP32 v3.1.0 #189

Closed dalathegreat closed 5 days ago

dalathegreat commented 4 weeks ago

What

The changes introduced in EPS32 v3.1.0 causes a runtime crash when trying to use this AsyncTCP library

assert failed: tcp_alloc /IDF/components/lwip/lwip/src/core/tcp.c:1851 (Required to lock TCPIP core functionality!)

How

We fix this by applying the fix in https://github.com/espressif/arduino-esp32/issues/10526 , suggested by mathieucarbou

Lukaswnd commented 3 weeks ago

In general it works for me. But you forgot to commit the AsyncTCP.h you added 2 functions, which also need to be added in the class declaration in the header. And you should check backward compability

mathieucarbou commented 1 week ago

@dalathegreat : fyi the initial fix was improved.

you can have a look at the community maintained forks here where several people are collaborating:

Ideally the author would need to merge all the changes from these forks in his own repos if he intends one day to resume the work and maintenance of these repos, and give collaborator access to people to ensure that these won't be dead again.

dalathegreat commented 1 week ago

Thanks @mathieucarbou , I have switched my Battery-Emulator project over to using your excellent forks of ESPAsyncWebServer & AsyncTCPsock!

I will close this PR since it obviosuly is not a repo that is taking in new contributions!

mathieucarbou commented 1 week ago

Thanks @mathieucarbou , I have switched my Battery-Emulator project over to using your excellent forks of ESPAsyncWebServer & AsyncTCPsock!

We are maintaining AsyncTCP, not AsyncTCPSock ;-)