me-no-dev / AsyncTCP

Async TCP Library for ESP32
GNU Lesser General Public License v3.0
757 stars 439 forks source link

mbed TLS support (client) #43

Open fremouw opened 5 years ago

fremouw commented 5 years ago

Hey,

I've added support for TLS using mbed TLS. It's only for the client side, but for most this is probably enough. You can enable it by setting the ASYNC_TCP_SSL_ENABLED build flag. Of course if anybody wants to add server side TLS support, feel free to do so.

tve commented 5 years ago

+1, I'm using fremouw's fork.

me-no-dev commented 5 years ago

So, sorry :) it's been a while since I had time to spend on this. I have just added some much needed fixes to Async TCP.

Please rebase the PR to match the current code. Also, it's a bit half-ass to add just client support. Do you think that adding server is much work?

fremouw commented 5 years ago

So, sorry :) it's been a while since I had time to spend on this. I have just added some much needed fixes to Async TCP.

Please rebase the PR to match the current code. Also, it's a bit half-ass to add just client support. Do you think that adding server is much work?

No worries! So, I totally agree with you that it would be better to also have server-side support. However, I would say that client-side TLS is used way more than server side, so from my perspective I would still go for it and merge. Btw, just noticed that @tve already rebased :-)

me-no-dev commented 5 years ago

please have a look at the comments I left there :) not much needed to get this into testing

GO74 commented 5 years ago

Well, I'm currently looking for Client and Server side TLS. I would like to use it in combination with mqtt-client and I believe that it would make a lot of sense to use it in that context.