Closed Vincent-SD closed 3 years ago
Hi Vincent, thanks for the first pull request ๐น
What happens now is that we go over the pull request contents in-depth, which is good practice, both for learning and also for future collaboration on open-source software.
Feedback:
.gitignore
in a separate commit from the code change fixing issue #39. Follow the guidelines in this: How to write a good commit messages
This pull request closes issue #39