Remove the `========` comments from Sass files

mediacurrent / theme_generator_8

Yeoman generator for Drupal Themes - lets you quickly set up a Drupal 8 theme with sensible defaults and best practices.

MIT License

100 stars 24 forks source link

Remove the `========` comments from Sass files #65

Closed zhawkins closed 4 years ago

zhawkins commented 4 years ago

GrumPHP throws an error for ====== code because it's part of how git conflicts are denoted. We're using that for SCSS comments in Sass files. No reason we can't update those comments to not use ========.

https://github.com/mediacurrent/theme_generator_8/blob/master/generators/app/templates/_src/patterns/global/global.scss

mariohernandez commented 4 years ago

PR has been created for this.

Tregonia commented 4 years ago

Issue has been resolved https://github.com/mediacurrent/theme_generator_8/commit/5c5116f7fc985cc5590c5dbf7eeb0cb1b7194c39