medic / cht-conf

A command-line interface for configuring Community Health Toolkit applications

https://communityhealthtoolkit.org

GNU Affero General Public License v3.0

22 stars 25 forks source link

chore(#621): update eslint to v8 #624

Closed m5r closed 2 months ago

m5r commented 3 months ago

Description

Update ESLint to v8 without migrating to the new configuration format

medic/cht-conf#621

Code review items

Readable: Concise, well named, follows the style guide, documented if necessary.
Documented: Configuration and user documentation on cht-docs
Tested: Unit and/or integration tests where appropriate
Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

m5r commented 3 months ago

@jkuester I was hoping to merge this to main after the previous PR but since Sonar won't play nice with my TODO comments I'm merging this to 621-update-non-breaking-deps instead and will merge the previous PR to main once this gets merged

m5r commented 2 months ago

How confident are we that this is not going to have a significant effect on the linting of partner configs? Seems like it should be pretty much passive since we are not actually changing any linting rules.

@jkuester I'm very confident as ESLint v8 still supports the config format we (and partner configs) are using, we have automated tests covering linting config code, and I ran the compile-app-settings command with this branch on a handful of the most recently updated partner configs without any issue. And yeah, worst case scenario, if they do run into a linting error they can always bypass it with the --debug flag or by overriding rules in their own .eslintrc config

medic-ci commented 1 month ago

:tada: This PR is included in version 4.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: