search

medismail / salattime

Nextcloud app for salat time
GNU Affero General Public License v3.0
7 stars 2 forks source link

i18n: Do no split sentences in multiple parts for translation #3

Closed rakekniven closed 2 days ago

rakekniven commented 1 week ago

The following code will cause trouble.

https://github.com/medismail/salattime/blob/8d0ea8f676781d4be30ecedac9bb3bcfb41b8766/lib/DAV/Calendar.php#L260

Please use one string and placeholders. Otherwise translators will struggle and some languages cannot be handled.

See how other nextcloud apps do it.

medismail commented 5 days ago

Hi, OK, I will update all text with multi strings.

medismail commented 2 days ago

Fixed in: 7824eed836457d24b46d002aa374ec82d3a0f36f