search

meeb / tubesync

Syncs YouTube channels and playlists to a locally hosted media server
GNU Affero General Public License v3.0
1.99k stars 130 forks source link

Automatic format retrieval option #10

Closed TwistTheNeil closed 3 years ago

TwistTheNeil commented 3 years ago

If it's possible, it would be nice to see an option which automatically picks the best video resolution and audio using youtube-dl's -f bestvideo+bestaudio param instead of selecting manually an option in the source configuration

Perhaps this was the intention with the fallback. But i'm still selecting the highest known video resolution and an audio codec

PS nice project, just stumbled on it. Hope to replace my cronjob mess soon!

meeb commented 3 years ago

Sure this might be a reasonable idea. I actually went to some lengths to re-implement the resolution and format detection to do what I wanted (best possible quality for the format with 60fps/hdr if available etc.) but the youtube-dl's 'best' is probably fine for a lot of other use cases as well. I'll see how sensible it is to add it. Thanks for the suggestion.

Edit: actually, try the fallback mechanism first, it should result it better quality matching that 'best' at the moment. If not, I'll look into it more.

TwistTheNeil commented 3 years ago

Thanks @meeb :)

TwistTheNeil commented 3 years ago

I'll look into the fallback option more tomorrow or over the weekend. I set it to 8k and tested with one channel and it seemed to get the correct video format but there were audio codecs with higher bitrate which was missed (different codec).

meeb commented 3 years ago

Ah, well you can just pick a different audio codec if you prefer, it'll match the desired codec at the highest bitrate over the highest general bitrate. If you find a video with some codec I've not found in my testing (not OPUS or M4A) spam the link in here and I'll add support for it.

meeb commented 3 years ago

After some poking about, this is going to be a pain to implement with the existing manual selection of codecs and resolutions implemented in TubeSync. I'll close this for now, but comment back on the issue or open a new more specific details if you find the current media format selection system isn't doing what you want. Personally, I'd prefer TubeSync kept better specific per-format selection in it rather than passing it off to youtube-dl which may change as the upstream is updated.

TwistTheNeil commented 3 years ago

Alright, yeah, no worries! Thanks for the update!