meerk40t / meerk40t

Hackable Laser software for K40 / GRBL / Fibre Lasers
MIT License
233 stars 62 forks source link

Fix hover issue on jog panel #2663

Closed jpirnay closed 2 weeks ago

jpirnay commented 2 weeks ago

Propagate previously swallowed events, fixes #2655

Summary by Sourcery

Bug Fixes:

sourcery-ai[bot] commented 2 weeks ago

Reviewer's Guide by Sourcery

The PR fixes a hover issue in the jog panel by propagating previously swallowed mouse events. This is implemented by adding event.Skip() calls to various button event handlers in the TimerButtons class, allowing the events to continue through the event chain.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added event propagation to button event handlers
  • Added event.Skip() to on_button_lost handler
  • Added event.Skip() to on_button_down handler
  • Added event.Skip() to on_button_up handler
  • Added event.Skip() to on_button_click handler
meerk40t/gui/navigationpanels.py
Code cleanup in navigation panel initialization
  • Removed unnecessary blank line between properties setup and timer initialization
meerk40t/gui/navigationpanels.py

Assessment against linked issues

Issue Objective Addressed Explanation
#2655 Fix buttons in the 'Jog' menu that remain in hover state after being un-hovered

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).