In channel.go within the Channel.WatchEvent function, the code checks result and uses its information to decide whether to send a notification. However, in notification_strategy.go, the NotificationStrategyData.ProcessStatus function updates the status and the number of notifications sent.
This means that in the case of #523, since the failure count is set to 2 and a failure occurs in the init state, the channel does not send a notification because it is in the init state. However, NotificationStrategyData considers the notification already sent and IsExceedMaxTimes returns true.
As a result, no notification is sent. To fix this problem, when in the init state, NotificationStrategyData should not be updated. According to the logic and comments in channel.go, init is a special state. This fix should be fine.
Fix #523
In
channel.gowithin theChannel.WatchEventfunction, the code checksresultand uses its information to decide whether to send a notification. However, innotification_strategy.go, theNotificationStrategyData.ProcessStatusfunction updates the status and the number of notifications sent.This means that in the case of #523, since the failure count is set to 2 and a failure occurs in the
initstate, the channel does not send a notification because it is in theinitstate. However,NotificationStrategyDataconsiders the notification already sent andIsExceedMaxTimesreturns true.As a result, no notification is sent. To fix this problem, when in the init state,
NotificationStrategyDatashould not be updated. According to the logic and comments inchannel.go,initis a special state. This fix should be fine.