Changed output from stderr to stdout if the checksum is ok.

megastep / makeself

A self-extracting archiving tool for Unix systems, in 100% shell script.

https://makeself.io

GNU General Public License v2.0

2.32k stars 372 forks source link

Changed output from stderr to stdout if the checksum is ok. #336

Closed vermaete closed 3 months ago

vermaete commented 3 months ago

If something if fine, it should not (IMHO) be on stderr. This could cause false alarms to users where makeself is embedded into another installer.

vermaete commented 3 months ago

@megastep

I was running the tests on the master and they are failing too. https://github.com/vermaete/makeself/actions/runs/10512542010

So could it be the failing tests where not related to my PR?

megastep commented 3 months ago

Right, it does look like something changed that makes the Mac tests fail, let me look into this...

megastep commented 3 months ago

The tests are now passing again (completely unrelated). I guess I am OK with this change as long as the quiet flag is honored for use cases when the output may need to be parsed.