mehah / otclient

An alternative tibia client for otserv written in C++20 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize
Other
269 stars 211 forks source link

fix: packet Canary PR : "cyclopedia house auction" # 3022 #970

Open kokekanon opened 1 week ago

kokekanon commented 1 week ago
SEND Packet test lua - otui
sendCyclopediaHouseAuction 0xAD (173)
GET Packet test lua - otui
GameServerCyclopediaHouseAuctionMessage 0xC3 (195)
GameServerCyclopediaHousesInfo 0xC6 (198)
GameServerCyclopediaHouseList 0xC7 (199)

Description

I was test. this pr https://github.com/opentibiabr/canary/pull/3022

PR sent packets when logging

ERROR: ProtocolGame parse message exception (12336 bytes, 5967 unread, last opcode is 0xc6 (198), prev opcode is 0x9f (159)): unhandled opcode 198
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1340)

I solved that problem, the rest is theoretical, I don't know how to test that.

last commits

26a2d60 "Merge branch 'main' into test-house" on Nov 12, 2024, 02:28 PM

Behavior

Actual

Packet error

Expected

Do this and that happens

Fixes

Type of change

How Has This Been Tested

untest , until the end of the pr

Test Configuration:

Checklist

ONLY APPROVE IF PR CANARY # 3022 IS murge. if not close xd

sonarcloud[bot] commented 4 days ago

Please retry analysis of this Pull-Request directly on SonarQube Cloud