meilisearch / charabia

Library used by Meilisearch to tokenize queries and documents
MIT License
261 stars 89 forks source link

Update wana_kana to 4.0.0 #312

Closed tats-u closed 1 month ago

tats-u commented 1 month ago

Pull Request

Related issue

What does this PR do?

wana_kana used to easily panic. The panicability made it difficult to adopt it in the Meilisearch core. Update it to the latest version that doesn't panic.

PR checklist

Please check if your PR fulfills the following requirements:

Thank you so much for contributing to Meilisearch!

ManyTheFish commented 1 month ago

Hello @tats-u, can you please re-add the Japanese transliteration in the default Japanese tokenization in line 42? :)

tats-u commented 1 month ago

@ManyTheFish I'll blame and revert the commit that disabled that feature in next week.

meili-bors[bot] commented 1 month ago

Build succeeded: