meilisearch / meilisearch-php

PHP wrapper for the Meilisearch API
https://meilisearch.com
MIT License
610 stars 97 forks source link

Federated multi-search example does not work #685

Open thijskuilman opened 1 month ago

thijskuilman commented 1 month ago

Description I'm using the federated multi-search feature of Meilisearch. I use the code example from the docs:

$client->multiSearch([
    (new SearchQuery())
      ->setIndexUid('movies'))
      ->setQuery('batman'),
    (new SearchQuery())
      ->setIndexUid('comics')
      ->setQuery('batman'),
  ],
  (new MultiSearchFederation())
);

However, this results in the following error:

afbeelding

This error only appears when I pass an empty MultiSearchFederation() instance, like in the docs. The error does not appear when I set a property of MultiSearchFederation, like (new MultiSearchFederation())->setLimit(limit: 100).

Possible solution See my PR

norkunas commented 1 month ago

But what's the point to send without anything?

curquiza commented 1 month ago

But what's the point to send without anything?

You can to say you want to apply a federated search without any settings Federated search will merge the results of your different search, contrary to a basic multi search

So, if indeed we cannot send an empty federation, it's a bug. Or maybe there is another way to do it I ignore