Open GabrielMcNeilly opened 2 years ago
inovramadani
commented
2 years ago Absolutely agree with @GabrielMcNeilly. This plugin causing crashes on my cypress because its specific dependency to cypress 4.5.0. It should have been sth like cypress > 4.5.0 maybe?
lmiller1990
commented
2 years ago I am also curious about the future of the plugin. I can help out - I have deep knowledge on Cypress internals. I'd say the first step would be updating to each major Cypress version.
The best option might simply be to fork or move the plugin to it's own org, if the original author is no longer using it or able to maintain it.
dhulme
commented
2 years ago See this thread: https://github.com/meinaart/cypress-plugin-snapshots/issues/194
I think there is still an issue with the github actions with are blocking PRs. I had a look at it last year but got a bit stuck. Maybe you have an idea?
I think @joetidee and @edimitchel have permission to merge PRs.
edimitchel
commented
2 years ago Not anymore, PR are failing and we cannot override PR restriction in case of PR build failing..
gearsdigital
commented
2 years ago The best option might simply be to fork or move the plugin to it's own org, if the original author is no longer using it or able to maintain it.
What does @meinaart say about that? Are you still interested in maintaining the plugin? Otherwise it might be a good idea to transfer the ownership to someone else. @lmiller1990 seems to be the perfect fit 😅
@dhulme What is the issue with the github actions?
dhulme
commented
1 year ago We've now migrated to https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff which works fine with Cypress 10 🥳
david-renner-dwg
commented
1 year ago @dhulme How difficult was the migration to https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff? I'm trying to set up github actions for my org's cypress testing and it looks like we're going to need an alternative to cypress-plugin-snapshots. My organization is still using v8.4.1, if that matters.
dhulme
commented
1 year ago It's pretty simple. It uses the same folder structure for snapshots. I'd suggest updating to cypress 10 first. You may need to regenerate all the screen shots as they were slightly different dimensions for me.
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: david-renner-dwg @.> Sent: Tuesday, August 16, 2022 10:26:53 PM To: meinaart/cypress-plugin-snapshots @.> Cc: Dave Hulme @.>; Mention @.> Subject: Re: [meinaart/cypress-plugin-snapshots] Maintaining this plugin (Issue #210)
@dhulmehttps://github.com/dhulme How difficult was the migration to https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff? I'm trying to set up github actions for my org's cypress testing and it looks like we're going to need an alternative to cypress-plugin-snapshots. My organization is still using v8.4.1, if that matters.
— Reply to this email directly, view it on GitHubhttps://github.com/meinaart/cypress-plugin-snapshots/issues/210#issuecomment-1217183251, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAJNN32RWPD3J7RFDGYUGT3VZQBR3ANCNFSM5QM7TPAQ. You are receiving this because you were mentioned.Message ID: @.***>
@meinaart Can you give me/someone/others permissions to approve/merge PRs etc for this project?
It's a pretty nice plugin but it is in need of a fair amount of updates. I and others would be interested in contributing/maintaining it if you are no longer able to do so.
Currently it seems it is being left to stagnate and will soon be unusable. Given there is no fantastic visual testing Cypress plugin imho, this has the opportunity to be the main one so it seems a waste to just leave it especially when there are people willing to contribute.