mekomsolutions / openmrs-module-initializer

The OpenMRS Initializer module is an API-only module that processes the content of the configuration folder when it is found inside OpenMRS' application data directory.
MIT License
23 stars 77 forks source link

AMPATH Form Translations should take into account the form version. #244

Open ibacher opened 1 year ago

mks-d commented 2 months ago

@ibacher is this still current or we can close this issue?

ibacher commented 2 months ago

This one still needs to be done. Specifically, when loading a new version of an AMPATH Form, we need to reload the translations for that form so we end up with the form resources attached to the new form.

mks-d commented 2 months ago

@ibacher I'm wondering why this was not needed more in our implementation(s), could you speak to it @Ruhanga?

If we could live without it until now, and that the React Form Engine supersedes the AMPATH Form Engine, then this issue may be closed no?

ibacher commented 2 months ago

There are two things that make this a little rare to come across:

  1. Most implementations are mono-lingual and so, as long as the form works in the target language (usually English) translations aren't needed.
  2. The issue only arises when you have a form available in multiple languages and release a new version of the form, but with no additional translation keys needed, e.g., because you added a question that just uses the concept string.

Basically, AFAIK, the only implementation to run up against this is the ICRC, but other non-English implementations are likely to run into this.

mks-d commented 2 months ago

the only implementation to run up against this is the ICRC

In that case it would be good for @icrc-fdeniger to read through this and let us know if this issue should remain open.

icrc-fdeniger commented 2 months ago

I would say yes as it's not specific to ICRC but to non mono-ligual implementations.

Ruhanga commented 2 months ago

This issue is duplicated by this other one.

I'm wondering why this was not needed more in our implementation(s), could you speak to it @Ruhanga?

@mks-d we re-discovered it when working with the Cambodia distro.