meld-cp / obsidian-encrypt

Hide secrets in your Obsidian.md vault
MIT License
563 stars 33 forks source link

Remembered password shouldn't be viewable #74

Closed MaxLap closed 1 year ago

MaxLap commented 1 year ago

If remember password is set, someone using my PC could access encrypted content during the timeout. That makes sense and is expected.

What is not expected is that someone using my PC could access the password itself by clicking on the glasses icon while the password is remembered. The password is, in a way, the most private part of the encrypted note, since it opens access to the note and possibly other notes / accounts.

Thanks for this great plugin.

meld-cp commented 1 year ago

Oh, like if you give someone access to your note... But not having your password exposed by the click of a button... Makes sense.

I could add an option to hide the glasses icon in settings.

Although, someone with enough knowhow could still reveal the password from the input box. So, it's probably better to not have the passwords remembered at all in that case.

But yes, at least a settings option would make it harder to have a password exposed than simply clicking a button.

MaxLap commented 1 year ago

Indeed, that would be a good improvement. As a side note, another change would make this need obsolete:

In Lastpass, when it remembers my password, it doesn't ask me at all for that duration.

Ideally, this would mean that while a password is remembered:

Doing this would solve all of the problems mentionned in this issue so far and be a better experience for the user.

meld-cp commented 1 year ago

I like it, linking to #63

meld-cp commented 1 year ago

added in next release