melishev / strapi-plugin-react-editorjs

📝 Plugin for Strapi Headless CMS, hiding the standard WYSIWYG editor on Editor.js
https://www.npmjs.com/package/strapi-plugin-react-editorjs
MIT License
171 stars 80 forks source link

Hotfix for onChange event #41

Open kgrosvenor opened 2 years ago

kgrosvenor commented 2 years ago

I noticed issues with the onChange event not always being updated towards strapi, now it does and allows empty blocks, pasting blocks from other windows, ctrl+a and backspace.

My IDE was flagging up value twice in the WYSIWYG properties so I have omitted the second declaration made

melishev commented 2 years ago

I just tested your changes and I didn't see any change in behavior

kgrosvenor commented 2 years ago

@melishev Have you tested diffferences between two version as i feel you did not:

Try these steps

It doesn't let you in current version, please retest from this angle and you'll see what i mean.

I have this running in strapi and it works better, its tricky to show difference but there is, it needs more edge case testing too see the issues though.

Hope all is well 👍

melishev commented 2 years ago

@kgrosvenor Okay, but conflicts need to be resolved before I can merge.

SalahAdDin commented 2 years ago

@kgrosvenor Did you fix all the conflicts?