melonDS-emu / melonDS

DS emulator, sorta
https://melonds.kuribo64.net
GNU General Public License v3.0
3.17k stars 523 forks source link

Music skips during scene changes in Chrono Trigger and Castlevania: Order of Ecclesia #92

Closed yuriks closed 2 years ago

yuriks commented 7 years ago

In both games, the game music skips forward (with no apparent crackling or buffering issues, it just skips forward a bit) by about a second when a new room/screen is entered. In Chrono Trigger this happens reliably when entering an area map coming from the world map. In Order of Ecclesia it happens sometimes when changing between certain screens.

There isn't any host-side CPU spike or slowdown in these situations, so it might be related to loading data from the cart?

Arisotura commented 7 years ago

Which melonDS version? 0.3 had an ARM7 DMA timing bug that mostly affected cart transfers.

yuriks commented 7 years ago

This is with the pre-0.4 build you sent me before. I'm not sure which commit that is from. This still happens with official 0.4.

yuriks commented 7 years ago

Found a super easy way to reproduce this in Order of Ecclesia: Just Repeatedly entering and exiting the menu will cause a skip, so it's super easy to notice if you just repeatedly mash start while in-game.

Video of the issue: 2017-07-16_16-19-42.zip

Arisotura commented 5 years ago

can you (or someone else) test this again pls?

yuriks commented 5 years ago

I'll test it when I'm back home in ~a week.

DarkSwan86 commented 4 years ago

Seem fixed on 0.9 on Castlevania OoE (E), can you check it?

poudink commented 4 years ago

I can't say for Chrono Trigger, but as far as Castlevania is concerned, this was indeed fixed in melonDS 0.7.1

averms commented 3 years ago

I tried leaving and entering the Manolia Cathedral in Chrono Trigger using melonDS 0.9.1 on Linux and I can't reproduce the bug.

Are you able to reproduce @yuriks?

averms commented 3 years ago

Never mind the last comment. The skip, which is fairly subtle, occurs when entering and exiting some areas but not others. I was able to reproduce on a brand new save by entering and exiting my own house.

This does not happen with deSmuME (which I am running inside flatpak just like melonDS).

Arisotura commented 2 years ago

can you test this again on the latest revision?

yuriks commented 2 years ago

oops, sorry for forgetting about this. I'll re-test in a few minutes

yuriks commented 2 years ago

Just tested on 0.9.3 and I can't reproduce any of the audio skips I'd mentioned before. So as far as I can tell this seems to be fixed!

For future reference, I went back and bisected the fix. It appears that 0.7 still had the issue, but it's not present in 0.7.1 or in several later versions I also tested.