search

melpa / package-build

Tools for assembling a package archive
https://github.com/melpa/melpa
25 stars 34 forks source link

Add basic support for elpa-packages.eld #79

Closed elken closed 1 year ago

elken commented 1 year ago

A new[1] package.el feature for installing packages from version control requires a file called "elpa-packages.eld" to provide a list of everything to install.

Continued from https://github.com/melpa/melpa/pull/8439

[1] https://github.com/emacsmirror/emacs/blob/309e6aaa6867cd9a33e185d929afe18a660a8151/lisp/emacs-lisp/package-vc.el

tarsius commented 1 year ago

I assume [Non]GNU ELPA already feature this file and tried downloading them to have a look. I did load package-vc and then ran package-refresh-contents but nothing appeared. What else do I have to do?

Edit: Ah, package-vc-install does the trick but still, do you know how to refresh this data at the same time as the non-vc data?

elken commented 1 year ago

I assume [Non]GNU ELPA already feature this file and tried downloading them to have a look.

I posted the link on the other issue, but it's https://elpa.gnu.org/packages/elpa-packages.eld

I did load package-vc and then ran package-refresh-contents but nothing appeared. What else do I have to do?

(package-vc-install 'blimp) for example to install blimp

tarsius commented 1 year ago

I have implemented this myself now on the vc branch. 832dc31033d89632a7d718b3bb8e240286e2696d replaces your commit. I have also taken the opportunity to cleanup the surrounding in the commits leading up to that.

Once we merge that, all packages have to be rebuild. The same applies to the additional commit cd7f5c6aac5d763eab94d0db240242458fab92bc. I want to avoid having to rebuild every package twice, so these will have to be merged together. But before that last commit can be merged, some things have to be sorted out with the Emacs maintainers.

(As we can see, the actual change isn't hard (though also not as trivial as your implementation would have us believe); but it should also be clear why I didn't just do it. There's a lot of additional work involved.)

milkypostman commented 1 year ago

Ok thanks @tarsius. We can coordinate this.

tarsius commented 1 year ago

Ok thanks @tarsius. We can coordinate this.

I'll ping you once things are ready on Emacs' side, which might take a while.

tarsius commented 1 year ago

I have implemented this myself now on the vc branch.

Merged.